Skip to content

Add current-process debug port access - #7005

Merged
penalosa merged 3 commits into
mainfrom
penalosa/current-process-debug-port
Aug 19, 2026
Merged

Add current-process debug port access#7005
penalosa merged 3 commits into
mainfrom
penalosa/current-process-debug-port

Conversation

@penalosa

@penalosa penalosa commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add current() to the workerdDebugPort binding
  • route it through an in-process WorkerdDebugPort capability without opening a TCP connection
  • retain the existing connect(address) behaviour for remote workerd processes

Testing

  • just format
  • bazel test //src/workerd/server:server-test@ --nocache_test_results --test_output=errors (cancelled before execution; relying on CI)

@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

2 similar comments
@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@penalosa Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@penalosa
penalosa marked this pull request as ready for review August 14, 2026 12:26
@penalosa
penalosa requested review from a team as code owners August 14, 2026 12:26
@penalosa penalosa mentioned this pull request Aug 14, 2026
Open
5 tasks
@github-actions

github-actions Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@codspeed-hq

codspeed-hq Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1

Comparing penalosa/current-process-debug-port (f03f576) with main (0cfe647)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

dom96
dom96 approved these changes Aug 19, 2026
View reviewed changes

@dom96 dom96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

Curious about the motivation in avoiding the TCP connection (PR description doesn't explain it).

harrishancock
harrishancock approved these changes Aug 19, 2026
View reviewed changes
Comment thread src/workerd/server/server-test.c++
@penalosa

penalosa commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Curious about the motivation in avoiding the TCP connection (PR description doesn't explain it).

In Miniflare, we want to be able to access an arbitrary Worker running within the same workerd process for dispatching (we won't be exposing this to users, just to power some internals)

@penalosa
penalosa merged commit 5ef8a1f into main Aug 19, 2026
31 checks passed
@penalosa
penalosa deleted the penalosa/current-process-debug-port branch August 19, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dom96 dom96 dom96 approved these changes
@harrishancock harrishancock harrishancock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@penalosa @dom96 @harrishancock